Repository navigation
add sub account deletion - #30
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 8, 2026
oshchyhol
marked this pull request as ready for review
September 8, 2026 09:22
oshchyhol
force-pushed
the
MT-23420-go-delete-sub-account
branch
from
September 9, 2026 11:40
3dd3f58 to
838d006
Compare
IgorDobryn
approved these changes
Sep 15, 2026
VladimirTaytor
approved these changes
Sep 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The API is getting
DELETE /api/organizations/{organization_id}/sub_accounts/{sub_account_id}. The SDK already lists and creates sub-accounts, so deletion is the missing piece.Changes
SubAccounts.Delete(ctx, subAccountID)– sends the DELETE request for the organization set withWithOrganizationID, returns*Responseanderror; sameerrNoOrganizationIDguard asListandCreateexamples/sub-accountsdeletes the sub-account it created after listingHow to test
Use an organization token with sub-account management permissions and a client created with
WithOrganizationID.client.SubAccounts.Delete(ctx, id)– returnserr == nil,resp.StatusCode == 204; the id is no longer inclient.SubAccounts.ListDeleteagain with the same id – returns an error with status 404Deletewith an id from another organization, or with a token without sub-account management permissions – error with status 403Deletewith an invalid token – error with status 401WithOrganizationIDand callDelete– returnserrNoOrganizationIDwithout sending a requestMAILTRAP_API_TOKEN=... MAILTRAP_ORGANIZATION_ID=... go run ./examples/sub-accounts– prints the created sub-account, the count, thendeleted sub-accountOrganization sub-accounts — list, create & deleteCompanion PRs
terraform-provider-mailtrapconsumes this module; the change is additive and safe.Caveat: merge and release only after the backend change ships; the endpoint is not in production yet.