Cleanup code (originally profession-related) - #39
Open
bluebear94 wants to merge 14 commits into
Open
Conversation
bluebear94
force-pushed
the
mf/cleanup-professions
branch
2 times, most recently
from
October 24, 2025 06:25
a1f9902 to
855778d
Compare
bluebear94
changed the title
bluebear94
force-pushed
the
mf/cleanup-professions
branch
from
October 31, 2025 19:16
41e467d to
11e7a0b
Compare
This avoids building a new list for every effect stack to remove. We do have to build a list once to avoid a CME, but we also limit its length to `count`.
bluebear94
force-pushed
the
mf/cleanup-professions
branch
from
November 16, 2025 18:02
b7135c7 to
a7794dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the quality of some of the code surrounding professions.
SkillItemTierfinal.EnumMapfor mapping fromSkillItemTiers to the respective items.SkillItemTiers become configurable, but in any case, the type ofTIERED_ITEM_MATSis now exposed asMap<..., Map<...>>instead of mentioning the concrete types.ProfessionMapItems#initso we don’t have to look up the elements once for every tier.BaseGearType#tagsfield andBaseGearType#getTags()method.AllyOrEnemy:AllyOrEnemy.non_ai_enemies.AllyOrEnemy#getMatchingEntities.