build: update forced dependencies#237
Merged
Merged
Conversation
magisk317
added
dependencies
审阅者指南（在小型 PR 上折叠显示）审阅者指南通过添加新的 Netty handler proxy 强制规则来更新 Gradle 的强制依赖版本，并刷新 Gradle 锁定文件以与更新后的依赖图保持一致。 启用更新强制规则后，Gradle 依赖解析流程图flowchart TD
A[Start build] --> B[Read build.gradle.kts dependency constraints]
B --> C[Apply force rules<br>- io.netty:netty-codec-http2:4.1.133.Final<br>- io.netty:netty-common:4.1.118.Final<br>- io.netty:netty-handler:4.1.118.Final<br>- io.netty:netty-handler-proxy:4.1.133.Final]
C --> D[Resolve dependency graph for each module]
D --> E[Compare resolved versions with existing gradle.lockfile]
E -->|Changes detected| F[Regenerate app/core/runtime gradle.lockfile]
E -->|No changes| G[Reuse existing lockfiles]
F --> H[Lock updated dependency graph]
G --> H
H --> I[Complete build]
文件级变更
技巧与命令与 Sourcery 交互
自定义你的体验访问你的 控制面板 来：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Gradle forced dependency versions by adding a new Netty handler proxy force rule and refreshes Gradle lockfiles to align with the updated dependency graph. Flow diagram for Gradle dependency resolution with updated force ruleflowchart TD
A[Start build] --> B[Read build.gradle.kts dependency constraints]
B --> C[Apply force rules<br>- io.netty:netty-codec-http2:4.1.133.Final<br>- io.netty:netty-common:4.1.118.Final<br>- io.netty:netty-handler:4.1.118.Final<br>- io.netty:netty-handler-proxy:4.1.133.Final]
C --> D[Resolve dependency graph for each module]
D --> E[Compare resolved versions with existing gradle.lockfile]
E -->|Changes detected| F[Regenerate app/core/runtime gradle.lockfile]
E -->|No changes| G[Reuse existing lockfiles]
F --> H[Lock updated dependency graph]
G --> H
H --> I[Complete build]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我在这里给出了一些总体反馈：
- 现在 Netty 版本出现了混用（例如 netty-handler 为 4.1.118.Final，而 netty-handler-proxy 和 netty-codec-http2 为 4.1.133.Final），这可能导致一些微妙的运行时问题；建议在可行的情况下，将所有 Netty 模块统一到同一个版本。
- 被强制的依赖列表在根 buildscript 和 subprojects 块中都出现了一份副本；建议将这些共享的约束提取到一个公共的配置或函数中，以避免未来更新时出现不一致。
给 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- 现在 Netty 版本出现了混用（例如 netty-handler 为 4.1.118.Final，而 netty-handler-proxy 和 netty-codec-http2 为 4.1.133.Final），这可能导致一些微妙的运行时问题；建议在可行的情况下，将所有 Netty 模块统一到同一个版本。
- 被强制的依赖列表在根 buildscript 和 subprojects 块中都出现了一份副本；建议将这些共享的约束提取到一个公共的配置或函数中，以避免未来更新时出现不一致。帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的 Review。
Original comment in English
Hey - I've left some high level feedback:
- Netty versions are now mixed (e.g., netty-handler 4.1.118.Final vs netty-handler-proxy and netty-codec-http2 at 4.1.133.Final), which can cause subtle runtime issues; consider aligning all Netty modules to a single version where feasible.
- The forced dependency list is duplicated in both the root buildscript and subprojects blocks; consider extracting the shared constraints into a common configuration or function to avoid divergence in future updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Netty versions are now mixed (e.g., netty-handler 4.1.118.Final vs netty-handler-proxy and netty-codec-http2 at 4.1.133.Final), which can cause subtle runtime issues; consider aligning all Netty modules to a single version where feasible.
- The forced dependency list is duplicated in both the root buildscript and subprojects blocks; consider extracting the shared constraints into a common configuration or function to avoid divergence in future updates.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated dependency force maintenance:
Summary by Sourcery
更新 Gradle 依赖强制规则，并刷新锁定文件以与更新后的依赖关系图保持一致。
构建：
io.netty:netty-handler-proxy添加强制版本。Original summary in English
Summary by Sourcery
Update Gradle dependency forcing and refresh lockfiles to align with the updated dependency graph.
Build: