fix: Prevent custom dimension inputs from clipping 4-digit values#884
Open
Vedhant26 wants to merge 1 commit into
Open
fix: Prevent custom dimension inputs from clipping 4-digit values#884Vedhant26 wants to merge 1 commit into
Vedhant26 wants to merge 1 commit into
Conversation
|
@Vedhant26 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Vedhant26!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @Vedhant26Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #876
What changed?
Added
min-w-20to the custom width and height inputs in thePresetSelectorcomponent.Why?
As mentioned in the issue, the inputs were getting squished by flexbox layout constraints to the point where 4-digit resolutions (like 1920 or 1080) were getting clipped and looking like "19" and "10". Enforcing a minimum width ensures the inputs stay wide enough to comfortably fit standard video dimensions without breaking the UI on smaller panels.
Let me know if you want me to make any adjustments! (GSSoC'26)