Skip to content

fix(presetSuggestion): use orientation-aware fallback for non-standard aspect ratios #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul-rajak-nsut wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −3
Open

fix(presetSuggestion): use orientation-aware fallback for non-standard aspect ratios #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1206114
feat: enable noUncheckedIndexedAccess and fix resulting type errors
rahul-rajak-nsut May 20, 2026
011a35b
fix: add JS validation for custom preset width/height inputs
rahul-rajak-nsut May 20, 2026
19d6020
fix(presetSuggestion): use orientation-aware fallback for non-standar…
rahul-rajak-nsut May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/presetSuggestion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ export function suggestPreset(width: number, height: number): SuggestedPresetId
return "square-1-1";
}

return "vertical-9-16";
return width >= height ? "landscape-16-9" : "vertical-9-16";
}
11 changes: 9 additions & 2 deletions src/lib/tests/presetSuggestion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,14 @@ describe("suggestPreset", () => {
expect(suggestPreset(1080, 1080)).toBe("square-1-1");
});

it("falls back to vertical 9:16 when no close ratio matches", () => {
expect(suggestPreset(1440, 900)).toBe("vertical-9-16");
it("falls back to landscape-16-9 for wide videos that don't closely match 16:9", () => {
expect(suggestPreset(1440, 900)).toBe("landscape-16-9"); // 16:10
expect(suggestPreset(1024, 768)).toBe("landscape-16-9"); // 4:3
expect(suggestPreset(1280, 800)).toBe("landscape-16-9"); // 16:10
});

it("falls back to vertical-9-16 for tall videos that don't closely match 9:16", () => {
expect(suggestPreset(900, 1440)).toBe("vertical-9-16"); // 10:16
expect(suggestPreset(768, 1024)).toBe("vertical-9-16"); // 3:4
});
});
Loading