Skip to content

fix: render image overlay in live preview window#846

Open
srinidhi-2006-bit wants to merge 4 commits into
magic-peach:mainfrom
srinidhi-2006-bit:fix/image-overlay-preview
Open

fix: render image overlay in live preview window#846
srinidhi-2006-bit wants to merge 4 commits into
magic-peach:mainfrom
srinidhi-2006-bit:fix/image-overlay-preview

Conversation

@srinidhi-2006-bit
Copy link
Copy Markdown
Contributor

Description

  • Fixed image overlays not appearing in the live preview window
  • Added real-time overlay rendering during editing
  • Synced overlay position, size, and opacity with preview
  • Added overlay image cleanup using object URL revocation
  • Ensured preview matches exported video output

Related Issue

Closes #811

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: srinidhi-2006-bit
  • Contribution level: Beginner

Screen Recording

Recording / Loom link:

screen-recording-2026-05-21-164131_iInRcNvN.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

@srinidhi-2006-bit is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

✅ PR Format Check Passed — @srinidhi-2006-bit

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @srinidhi-2006-bit!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:docs Documentation type:feature New feature type:refactor Code refactor labels May 21, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @srinidhi-2006-bit! Thanks for the PR. There's one issue preventing merge:

Accidental file committed

The diff contains a file literally named e -i HEAD~2 — this looks like an accidentally committed git log output from a git log -i HEAD~2 command run in the wrong directory. Please remove this file and push again:

git rm 'e -i HEAD~2'
git commit -m 'chore: remove accidentally committed file'
git push

The actual code changes (PrivacyBanner, VideoEditor, VideoPreview) look good — just need to clean up that stray file!

@srinidhi-2006-bit srinidhi-2006-bit force-pushed the fix/image-overlay-preview branch from 7c03e4a to a4cac89 Compare May 21, 2026 18:09
@srinidhi-2006-bit
Copy link
Copy Markdown
Contributor Author

Resolved the merge conflicts, cleaned up the branch, and verified the build locally. The overlay preview functionality is now working correctly with successful production build output.

Before merging the PR, could you please add the gssoc:approved label so the contribution can be counted under GSSoC'26? Thank you!

@srinidhi-2006-bit srinidhi-2006-bit force-pushed the fix/image-overlay-preview branch from a4cac89 to ab5e856 Compare May 21, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]Image overlay not visible in preview window

2 participants