feat: add custom preset support with localStorage persistence#842
feat: add custom preset support with localStorage persistence#842srinidhi-2006-bit wants to merge 2 commits into
Conversation
|
@srinidhi-2006-bit is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ PR Format Check Passed — @srinidhi-2006-bitBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
👋 Thanks for your PR, @srinidhi-2006-bit!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
da86bd2 to
7422f97
Compare
|
Hey @srinidhi-2006-bit! The custom preset persistence feature is a great addition and the implementation is solid. A couple of things to address before merge: 1. QUICK_ACTIONS row removed The PR removes the entire quick-action row (Reels, TikTok, YouTube Short, YouTube, Twitter/X buttons) from PresetSelector. These one-click social media shortcuts are a core UX feature — please restore them. The custom presets UI can be added alongside the existing QUICK_ACTIONS row, not as a replacement. 2. Using the native Please fix these two items and the PR will be in great shape to merge! |
|
Thanks for the review! The QUICK_ACTIONS row has been restored and preserved, and the previous native prompt-based flow has been removed/refined to keep the UX consistent with the existing UI. I also verified the latest changes with a successful local production build. Before merging the PR, could you please add the |
beef066 to
524a3fa
Compare
Description
Related Issue
Closes #683
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link:
screen-recording-2026-05-21-144719_pxEf3Aoq.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in