Skip to content

feat: add custom preset support with localStorage persistence#842

Open
srinidhi-2006-bit wants to merge 2 commits into
magic-peach:mainfrom
srinidhi-2006-bit:feat/custom-presets
Open

feat: add custom preset support with localStorage persistence#842
srinidhi-2006-bit wants to merge 2 commits into
magic-peach:mainfrom
srinidhi-2006-bit:feat/custom-presets

Conversation

@srinidhi-2006-bit
Copy link
Copy Markdown
Contributor

@srinidhi-2006-bit srinidhi-2006-bit commented May 21, 2026

Description

  • Added custom preset save functionality
  • Added localStorage persistence for saved presets
  • Added apply and delete preset actions
  • Added max limit for saved presets
  • Improved preset management UI

Related Issue

Closes #683

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: srinidhi-2006-bit
  • Contribution level: Beginner

Screen Recording

Recording / Loom link:

screen-recording-2026-05-21-144719_pxEf3Aoq.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

@srinidhi-2006-bit is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

✅ PR Format Check Passed — @srinidhi-2006-bit

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @srinidhi-2006-bit!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 21, 2026
@magic-peach magic-peach added the level:intermediate Intermediate level - 35 pts label May 21, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @srinidhi-2006-bit! The custom preset persistence feature is a great addition and the implementation is solid. A couple of things to address before merge:

1. QUICK_ACTIONS row removed

The PR removes the entire quick-action row (Reels, TikTok, YouTube Short, YouTube, Twitter/X buttons) from PresetSelector. These one-click social media shortcuts are a core UX feature — please restore them. The custom presets UI can be added alongside the existing QUICK_ACTIONS row, not as a replacement.

2. prompt() for preset naming

Using the native window.prompt() dialog works but breaks the app's visual consistency. Please replace it with an inline text input — something like a small input field that appears in the UI when clicking "Save Preset", or a modal styled with the existing design system, rather than a browser prompt() call.

Please fix these two items and the PR will be in great shape to merge!

@srinidhi-2006-bit
Copy link
Copy Markdown
Contributor Author

Thanks for the review! The QUICK_ACTIONS row has been restored and preserved, and the previous native prompt-based flow has been removed/refined to keep the UX consistent with the existing UI. I also verified the latest changes with a successful local production build.

Before merging the PR, could you please add the gssoc:approved label so the contribution can be counted under GSSoC'26? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: custom preset save/load — let users name and save their own export presets

2 participants