Skip to content

fixed the overlapping content#746

Open
pratyuxxhh wants to merge 4 commits into
magic-peach:mainfrom
pratyuxxhh:fix/custom-frame-overlapping-value-inside-field
Open

fixed the overlapping content#746
pratyuxxhh wants to merge 4 commits into
magic-peach:mainfrom
pratyuxxhh:fix/custom-frame-overlapping-value-inside-field

Conversation

@pratyuxxhh
Copy link
Copy Markdown

Description

Fixed the overlapping issue in the custom width/height input fields where the frame/border was covering the numeric input and spinner controls.

Additionally, fixed incorrect frame ratio rendering behavior:

  • Ratios like 1:1 were not displaying as proper squares.
  • Width and height scaling behavior was inconsistent.
  • Updated the ratio handling logic so frame dimensions now render correctly according to the selected aspect ratio.

Also corrected independent resizing behavior:

  • Changing width now affects only width.
  • Changing height now affects only height unless aspect ratio lock is enabled.

Related Issue

Closes #738

Type of Contribution

  • Bug fix
  • GSSoC contribution

Participant Info

  • GitHub username: pratyuxxhh
  • Contribution level: Intermediate

Screen Recording

Reframe.Resize.trim.and.export.videos.in.your.browser.-.Google.Chrome.2026-05-19.21-43-56.mp4

Recording / Loom link:

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@pratyuxxhh is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

⚠️ PR Format Issues — @pratyuxxhh

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @pratyuxxhh!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 19, 2026
@magic-peach magic-peach added the level:intermediate Intermediate level - 35 pts label May 21, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @pratyuxxhh! The PR title says "fixed the overlapping content" but the diff only shows changes to .gitignore and bun.lock — no UI or layout code is changed.

It looks like the branch may not have the actual fix in it, or the wrong branch was submitted. Could you:

  1. Verify your branch has the intended overlapping content fix
  2. If so, make sure it's been committed and pushed

Also, the bun.lock change removes thousands of packages from the lockfile — if this is a genuine regeneration, please make sure it was done with bun install and that the app still builds correctly.

@pratyuxxhh
Copy link
Copy Markdown
Author

pratyuxxhh commented May 21, 2026

hie @magic-peach , i reviewed my PR , i made the UI changes but accidently made changes in the bun and gitignore file also , i am restoring it , else everything works fine .

image

@github-actions github-actions Bot added the level:beginner Beginner level - 20 pts label May 21, 2026
Add bun.lockb and package-lock.json to .gitignore
@pratyuxxhh
Copy link
Copy Markdown
Author

@magic-peach , i restored the bun.lock and .gitignore file , please review the changes , else the UI changes are working perfectly fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts level:beginner Beginner level - 20 pts level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] the custom frame UI is not good

2 participants