perf(thumbnail): optimize thumbnail generation using Blobs, Object URLs and batched state updates#718
Open
AdityaM-IITH wants to merge 1 commit into
Conversation
…Ls and batched state updates
|
@AdityaM-IITH is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @AdityaM-IITH!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a significant performance overhaul to the video frame generation pipeline inside
ThumbnailStrip.tsx. It eliminates severe client-side browser heap degradation (~1.8MB+ reduction over baseline video lengths) and aggressive quadratic DOM rendering cascades during asset ingestion.Changes Executed
toDataURL()) to lightweight binary object pointers usingcanvas.toBlob().URL.createObjectURL(blob)). Tracked active pointers inside a mutableobjectUrlsRefand introduced an explicit clean-up hook utilizingURL.revokeObjectURL()during component unmounts or timeline resets to completely prevent memory leaks.🎥 Local Verification Tape
bunx tsc --noEmitandbun run lintpass flawlessly with zero type errors.reframe.thumb.strip.mp4
Checklist