Skip to content

feat: activate recipe prop overlay loop and reposition toggle to top-left#716

Open
shivashanker123 wants to merge 1 commit into
magic-peach:mainfrom
shivashanker123:feat/enable-preview-overlay
Open

feat: activate recipe prop overlay loop and reposition toggle to top-left#716
shivashanker123 wants to merge 1 commit into
magic-peach:mainfrom
shivashanker123:feat/enable-preview-overlay

Conversation

@shivashanker123
Copy link
Copy Markdown
Contributor

Description

This PR activates and optimizes the dormant aspect-ratio framing/letterbox helper overlay system inside the VideoPreview component.

Key Changes:

  1. Activated Core Overlay Logic: Connected the active state by passing the missing recipe prop down to <VideoPreview /> inside src/components/VideoEditor.tsx (Line 133). This activates the pre-existing, optimized crop boundary calculations in Fill mode and letterbox structures in Fit mode.
  2. Optimized Toggle Accessibility: Repositioned the Show Overlay / Hide Overlay button wrapper from the bottom-right corner to the top-left viewport corner of the video player preview card. This completely resolves the layout collision where default browser HTML5 playback controls and timeline elements blocked button interaction.

Related Issue

Closes #714


Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: shivashanker123
  • Contribution level (Beginner/Intermediate/Advanced): Advanced

Screen Recording

🎬 Feature Implementation & Aspect Ratio Flow Demo

Screen.Recording.2026-05-19.142100.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@shivashanker123 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @shivashanker123!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @shivashanker123

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable and optimize aspect ratio crop/letterbox overlays in VideoPreview

1 participant