feat: improve navbar ui ux design#708
Open
yuvraj-k-singh wants to merge 2 commits into
Open
Conversation
Signed-off-by: yuvraj-k-singh <yuvrajstudentbussiness@gmail.com>
|
@yuvraj-k-singh is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @yuvraj-k-singhBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @yuvraj-k-singh!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:advanced
Author
|
Hi @magic-peach , I’ve completed the Navbar UI/UX improvement and addressed the related changes. Could you please review my PR when you get a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completely improve header layout by replacing the previous split-file design with a unified, highly optimized, and responsive custom
<Navbar />component.🔍 Previous Design Analysis
layout.tsx, while the "⭐ Star on GitHub" link was hardcoded as a fixed element insidepage.tsx.🚀 Key Improvements Introduced in this PR
<Navbar />component for better maintainability and cleaner code architecture.sm:hiddenandhidden sm:inline). On mobile devices, the long text string safely collapses into a clean, compact[ GitHub Icon | ⭐ ]layout to save premium screen real estate without breaking container dimensions.var(--bg),var(--border),var(--surface),var(--text)). The entire header now shifts flawlessly and seamlessly across Light, Dark, and High Contrast mode tokens.suppressHydrationWarningflag to the<body>element withinlayout.tsxto handle third-party browser extensions or shortcut script injections without triggering Next.js server-to-client mismatch runtime overlays.Related Issue
Closes #636
Type of Contribution
Participant Info
Screen Recording
navbar.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in