fix: replace NodeJS.Timeout with environment-agnostic ReturnType to unblock CI#650
fix: replace NodeJS.Timeout with environment-agnostic ReturnType to unblock CI#650AdityaM-IITH wants to merge 1 commit into
Conversation
|
@AdityaM-IITH is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Thanks for your PR, @AdityaM-IITH!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
@AdityaM-IITH please create a screen recording of the changes made and tests passing |
|
Hey @AdityaM-IITH! 👋 We've added a new requirement for all PRs: a screen recording showing your changes working on your local machine must be attached before a PR can be merged. Please add a recording to this PR that shows:
How to record:
Once you have the recording, drag the file directly into a comment on this PR, or paste a Loom link. This is now a hard requirement — see CONTRIBUTING.md for full details. Thanks for contributing to Reframe! 🎬 |
|
Here is the required local pipeline verification recording using OBS: 🎥 Local Verification Proof
PR.650.reframe.mp4The type boundaries are fully unified now. Ready for maintainer merge! |
Overview
Resolves a TypeScript compilation vulnerability caused by environment-specific typing leaking into a frontend React component.
TipCarousel.tsxwas previously relying onNodeJS.Timeoutfor its interval and timeout refs. In strict browser-targeted CI build steps (or when@types/nodeis not explicitly loaded into the frontend context), this causes thetsccompiler to throw a namespace resolution error, breaking the pipeline.Changes Executed
timeoutRefto use the environment-agnosticReturnType<typeof setTimeout>intervalRefto use the environment-agnosticReturnType<typeof setInterval>This ensures the component typing is strictly inferred from the execution environment without relying on Node-specific globals, allowing
npm run type-checkto pass flawlessly across all environments.Type of Change
Checklist
tsc --noEmit) passes cleanly