Skip to content

feat: add horizontal and vertical flip controls#553

Open
Swetanegi05 wants to merge 7 commits into
magic-peach:mainfrom
Swetanegi05:feat/flip-controls
Open

feat: add horizontal and vertical flip controls#553
Swetanegi05 wants to merge 7 commits into
magic-peach:mainfrom
Swetanegi05:feat/flip-controls

Conversation

@Swetanegi05
Copy link
Copy Markdown

Closes #117

Changes Made

  • Added flipHorizontal and flipVertical fields to EditRecipe type in types.ts
  • Added flipHorizontal and flipVertical to DEFAULT_RECIPE
  • Added hflip and vflip filters to FFmpeg filter chain in ffmpeg.ts
  • Added Flip H and Flip V toggle buttons in RotateControl.tsx
  • Added CSS transform for flip preview in VideoPreview.tsx

Keyboard Navigation

  • Flip buttons are toggleable — click to enable/disable
  • Works independently and combined with rotation
Screenshot 2026-05-17 135021 Screenshot 2026-05-17 135047 Screenshot 2026-05-17 135132

@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

@Swetanegi05 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

✅ PR Format Check Passed — @Swetanegi05

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:design UI/UX design labels May 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Swetanegi05!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@magic-peach magic-peach added the gssoc'26 GirlScript Summer of Code 2026 label May 17, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @Swetanegi05! This PR modifies package-lock.json — this project uses bun.lock exclusively and package-lock.json should not be present or modified.

Please remove it entirely:

rm package-lock.json
git add package-lock.json
git commit -m "chore: remove package-lock.json"
git push

Once that is resolved and CI passes, the flip controls implementation will be reviewed!

@magic-peach
Copy link
Copy Markdown
Owner

Hey @Swetanegi05! This PR has merge conflicts with main. Please rebase:

git fetch upstream
git rebase upstream/main
# resolve any conflicts
git push --force-with-lease origin feat/flip-controls

Once rebased and CI passes, we can review the flip controls feature for merge!

@magic-peach magic-peach added level:intermediate Intermediate level - 35 pts type:feature New feature and removed level:advanced Advanced level - 55 pts labels May 17, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @Swetanegi05! Flip controls are a useful feature. This PR has merge conflicts with main and has no CI check results. Please rebase on main:

git fetch origin
git rebase origin/main
git push --force-with-lease

Once CI (build/lint/typecheck) all pass, this can be reviewed.

@magic-peach
Copy link
Copy Markdown
Owner

Hey @Swetanegi05! This PR has merge conflicts with the latest main. Please rebase to resolve them and trigger fresh CI:

git fetch origin
git rebase origin/main
git push --force-with-lease

Once CI (build/lint/typecheck) passes, we'll review and merge!

@github-actions github-actions Bot added the level:advanced Advanced level - 55 pts label May 18, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @Swetanegi05! This PR had merge conflicts with main — I've resolved them automatically and pushed. Conflicts were resolved by keeping main's versions of core files while preserving your feature changes. CI has been re-triggered. Once it passes, we'll review for merge!

@magic-peach magic-peach removed the level:advanced Advanced level - 55 pts label May 18, 2026
@github-actions github-actions Bot added the level:advanced Advanced level - 55 pts label May 18, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @Swetanegi05! 👋

We've added a new requirement for all PRs: a screen recording showing your changes working on your local machine must be attached before a PR can be merged.

Please add a recording to this PR that shows:

  1. bun run dev running at http://localhost:3000
  2. The full working flow of your change (demonstrate the feature/fix end-to-end)
  3. Any tests passing — if your change touches logic with tests, show bun run lint and bunx tsc --noEmit completing without errors in the terminal

How to record:

  • macOS: Cmd + Shift + 5 → Record Selected Portion, or QuickTime Player
  • Windows: Win + G → Xbox Game Bar → Capture
  • Linux: OBS Studio, GNOME Screenshot, or kazam
  • Any OS: Loom (free, easy to share)

Once you have the recording, drag the file directly into a comment on this PR, or paste a Loom link. This is now a hard requirement — see CONTRIBUTING.md for full details.

Thanks for contributing to Reframe! 🎬

@Swetanegi05 Swetanegi05 force-pushed the feat/flip-controls branch from 056c4c6 to 34074fd Compare May 19, 2026 06:18
@Swetanegi05 Swetanegi05 force-pushed the feat/flip-controls branch from 23198c3 to f559135 Compare May 19, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts level:intermediate Intermediate level - 35 pts type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add mirror/flip horizontal and vertical options

2 participants