[MNOE-1280] Cleared instances cache to refresh apps & products#541
[MNOE-1280] Cleared instances cache to refresh apps & products#541RidaAhmad wants to merge 3 commits into
Conversation
| $state.go("home.subscriptions", {subType: 'cart'}) | ||
| else | ||
| clearInstancesCache() | ||
| # Reload dock apps |
There was a problem hiding this comment.
@MAhsenArif Please if you can confirm if we're good to remove this reload dock apps block of code as it no longer seems to be required now, will appreciate your input on this so you can confirm if it ain’t needed for cart or any other related functionalities.
Thank you,
There was a problem hiding this comment.
@RidaAhmad We still need this for the impac dashboard(if it is enabled) as this code is responsible for reloading the dock apps.
It isnt, however related to the cart subscriptions reloading as that is a separate condition branch(the if part of this code).
There was a problem hiding this comment.
@RidaAhmad On a deeper look, it seems that since we have a watcher added in the app docks component, it does do the appInstance cache refresh on it's own. This watcher will always get triggered because the app dock component is completely removed from DOM and re-added whenever we switch to and fro from Impac Dasboard.
The same behaviour is happening for the apps dashboard(tile view)
So it should be safe to remove the dock reload from here. and just keep the clearInstancesCache() method.
FYI @adamaziz15 @ouranos
There was a problem hiding this comment.
@MAhsenArif Yeah, seems to work fine without having to reload dock apps from here.
We can remove it for now and revert in case of any issue later.
Thank you for your input.
RidaAhmad
force-pushed
the
mnoe-1280-refresh-app-and-product-instances
branch
from
303bfbc to
3ee96a3
Compare
| @@ -1,5 +1,5 @@ | |||
| angular.module 'mnoEnterpriseAngular' | |||
| .controller('ProvisioningConfirmCtrl', ($scope, $state, $stateParams, $log, MnoeOrganizations, MnoeProvisioning, MnoeAppInstances, MnoeConfig, ProvisioningHelper, schemaForm, toastr) -> | |||
| .controller('ProvisioningConfirmCtrl', ($scope, $state, $stateParams, $log, MnoeOrganizations, MnoeProvisioning, MnoeAppInstances, MnoeConfig, ProvisioningHelper, schemaForm, toastr, MnoeProductInstances) -> | |||
There was a problem hiding this comment.
Line size increased. Might need to adjust indentation of the file.
There was a problem hiding this comment.
Feedback incorporated, thanks.
RidaAhmad
changed the title
3 participants
Uh oh!
There was an error while loading. Please reload this page.