[OPALSUP-290] Role change not reflected immediately on Teams.#535
Open
zohaibahmeds63 wants to merge 1 commit into
Open
[OPALSUP-290] Role change not reflected immediately on Teams.#535zohaibahmeds63 wants to merge 1 commit into
zohaibahmeds63 wants to merge 1 commit into
Conversation
MAhsenArif
approved these changes
Aug 13, 2018
Contributor
|
@zohaibahmeds63 could you rebase to solve conflicts? Thanks |
Contributor
|
Rebased to solve conflict |
ouranos
reviewed
Aug 22, 2018
ouranos
left a comment
Contributor
There was a problem hiding this comment.
@adamaziz15 what do you think?
The logic is stating to get quite complicated:
updateNbOfSuperAdmin()
# Update user role
if obj.email == MnoeCurrentUser.user.email
$scope.user_role = obj.role
rolesToDisplay()
clearInstancesCache()
reloadCurrentOrganization()
MnoeTeams.updateTeamMemberRole(obj)
self.close()
adamaziz15
reviewed
Aug 22, 2018
adamaziz15
left a comment
Contributor
There was a problem hiding this comment.
@ouranos I agree, it's already gotten a bit complex before this.
I'm not sure how to fix this role issue though, do you think it would be better to simplify this a bit and trigger a refresh instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MnoeTeamsafter role has been successfully updated on Members tab in Company screen.