[MNOE-406] Added logic to request for unscoped data when showing dashboard apps#425
Open
MAhsenArif wants to merge 3 commits into
Open
[MNOE-406] Added logic to request for unscoped data when showing dashboard apps#425MAhsenArif wants to merge 3 commits into
MAhsenArif wants to merge 3 commits into
Conversation
ouranos
approved these changes
Feb 19, 2018
|
|
||
| appInstancesPromise = null | ||
| @getAppInstances = -> | ||
| @getAppInstances = (force = false) -> |
Contributor
There was a problem hiding this comment.
The force is here to force unscoping?
In this case, it might more obvious to call it unscoped? And also add a quick comment on both @getAppInstance and @fetchAppInstance
MAhsenArif
force-pushed
the
delisted_apps_logo
branch
from
6890d44 to
1891748
Compare
ouranos
reviewed
Feb 22, 2018
ouranos
left a comment
ouranos
left a comment
Contributor
There was a problem hiding this comment.
Just a little style change on the Restangular call
| -> | ||
| _self.appInstancesPromise = MnoeApiSvc.one('organizations', MnoeOrganizations.selectedId).one('/app_instances').get().then( | ||
| query = if unscoped == true then '?unscoped=true' else '' | ||
| _self.appInstancesPromise = MnoeApiSvc.one('organizations', MnoeOrganizations.selectedId).one('/app_instances' + query).get().then( |
Contributor
There was a problem hiding this comment.
For query parameters, you can pass an object to get():
params = if unscoped then {unscoped: true} else {}
xxx.one('/app_instances').get(params)
MAhsenArif
force-pushed
the
delisted_apps_logo
branch
from
1891748 to
18b789c
Compare
ouranos
approved these changes
Mar 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.