[MNOE-497] [WIP] Move rails pages to SPA#236
Open
adamaziz15 wants to merge 18 commits into
Open
Conversation
alexnoox
reviewed
Aug 9, 2017
alexnoox
left a comment
alexnoox
left a comment
Contributor
There was a problem hiding this comment.
Hi @adamaziz15,
I had a quick look at this WIP PR. The structure seems good to me. I wrote a few comments. Let me know when this is ready for a full review. Cheers.
- For the select LESS styles in
auth.less, please make sure that they are used and useful. They seem hacky to me. - After a second look a lot of stuff seems not used in the styles. This project has a strong legacy, time to clean it up! 😄
| basePath = $windowProvider.$get().location.origin | ||
| AuthProvider.loginPath(basePath + '/mnoe/auth/users/sign_in') | ||
| AuthProvider.logoutPath(basePath + '/mnoe/auth/users/sign_out') | ||
| AuthProvider.registerPath(basePath + '/mnoe/auth/users/') |
Contributor
There was a problem hiding this comment.
Please use a constant object to define those paths (eg. URI.login)
| } | ||
| } | ||
|
|
||
| input.fluroblue[type=radio] { |
Contributor
There was a problem hiding this comment.
fluroblue is color specific to maestrano, please use an agnostic selector name and remove those occurences.
| $window.location.href = '/' | ||
| toastr = $injector.get('toastr') | ||
|
|
||
| toastr.error('User is not connected!') |
Contributor
There was a problem hiding this comment.
We should i18n this toastr
|
|
||
|
|
||
|
|
||
|
|
| ) | ||
| # Configure auth routes | ||
| .config((AuthProvider, AuthInterceptProvider) -> | ||
| AuthProvider.loginPath('/mnoe/auth/users/sign_in') |
Contributor
There was a problem hiding this comment.
Please use a constant to define those path strings
adamaziz15
force-pushed
the
feature/497-move-rails-pages
branch
from
5bbe1e0 to
7d6001e
Compare
adamaziz15
force-pushed
the
feature/497-move-rails-pages
branch
from
7d6001e to
154e2d1
Compare
adamaziz15
force-pushed
the
feature/497-move-rails-pages
branch
from
154e2d1 to
33f6872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alexnoox @ouranos
Sign in page works well and the rest of the application seems to run fine after the changes so far.
Moving on to the other rails pages but need to come back to take care of some functionality on the login page: