S2.UI.Accordion does not hide content on initialization#25
Open
Korkonius wants to merge 3 commits intomadrobby:masterfrom
Korkonius:master
Open
S2.UI.Accordion does not hide content on initialization#25Korkonius wants to merge 3 commits intomadrobby:masterfrom Korkonius:master
Korkonius wants to merge 3 commits intomadrobby:masterfrom
Korkonius:master
Conversation
… behaviour Signed-off-by: Eirik Ottesen <Korkonius@gmail.com>
Conflicts: src/ui/controls/accordion.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon creating a new S2.UI.Accordion all content remains visible until a header that triggers animation is clicked.
Attached patch changes this behavior by explicitly hiding all content not specified by the (new) defaultIndex option.
I am unsure if this was an issue in the Alpha releases but with Beta 1 i have had the problem on 2 different pages using the jQuery Themeroller as several tutorials suggest should work out of the box.
Due to this being my first experience with GIT the changes are spread over 3 commits to minimize the footprint of my patch in the existing S2 code.
Best Regards,
Eirik Ottesen