Skip to content

Fixed version numbering - #6

Merged
madebybye merged 1 commit into
mainfrom
celebration
Jan 7, 2026
Merged

madebybye merged 1 commit into
mainfrom
celebration

Conversation

@madebybye

Copy link
Copy Markdown
Owner

No description provided.

@claude

claude Bot commented Jan 5, 2026

Copy link
Copy Markdown

PR Review: Fixed version numbering

Summary

This PR updates the marketing version from 1.1 to 2.0.0 in both Debug and Release configurations.

Code Quality ✅

  • Consistent: Both Debug and Release configurations are updated identically
  • Clean change: No extraneous modifications to the project file
  • Proper format: Uses semantic versioning format (MAJOR.MINOR.PATCH)

Observations

Semantic Versioning Format

The change moves from 1.1 (two-part version) to 2.0.0 (three-part semantic version). This is an improvement as it follows semantic versioning conventions more closely:

  • ✅ Now uses MAJOR.MINOR.PATCH format
  • ✅ Indicates a major version bump (breaking changes or significant new features)

Potential Considerations

  1. Build Number (CURRENT_PROJECT_VERSION):

    • The CURRENT_PROJECT_VERSION remains at 1
    • Consider whether this should also be incremented or reset for a new major version
    • This is the build number that appears in App Store Connect
  2. Version Consistency:

    • Ensure any version references in release notes, documentation, or marketing materials are updated to match
    • Verify this aligns with your release/branching strategy
  3. App Store Submission:

    • If submitting to App Store, ensure 2.0.0 is higher than any previously submitted version
    • The combination of MARKETING_VERSION and CURRENT_PROJECT_VERSION creates the full version string (e.g., 2.0.0 (1))

Recommendations

  • Approve - The change is correct and consistent
  • 💡 Consider incrementing CURRENT_PROJECT_VERSION if this is a new build
  • 💡 Verify that a major version bump (1.x → 2.0) aligns with your release strategy
  • 💡 Ensure changelog/release notes reflect what's new in version 2.0.0

Security ✅

No security concerns with this change.

Performance ✅

No performance impact.

Test Coverage

Version number changes don't require unit tests, but consider:

  • Manual testing to verify the version displays correctly in the app
  • Checking that app updates work properly from 1.1 to 2.0.0

Review completed by Claude Code

@madebybye
madebybye merged commit eb96d40 into main Jan 7, 2026
1 check passed
@madebybye
madebybye deleted the celebration branch January 7, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant