Allow reusing runner scale set if it exists#65
Merged
Conversation
- Add `MANAGE_RUNNER_SCALE_SETS` environment variable to control whether to manage runner scale sets
If set to true, deletes any existing runner scale set with the same name on startup and deletes the scale set on exit (the old behavior).
If set to false, reuses an existing scale set if found and skips deletion on exit.
- Fix message session closing
The message session was never closed and it was impossible to reuse the scaleset
- Delete the scaleset if the active session is stale
In case the session was no properly closed, the scaleset needs to be deleted and a new one created
relwell
reviewed
May 27, 2026
| } | ||
|
|
||
| func (l *LeveledLogger) Error(msg string, keysAndValues ...interface{}) { | ||
| for i := 1; i < len(keysAndValues); i += 2 { |
Contributor
There was a problem hiding this comment.
This is kind of confusing, and it might be nice to have a comment that we're iterating through until we find the error we want to get more info on.
Collaborator
Author
There was a problem hiding this comment.
Good point. I have added an explanation. Let me know what you think
relwell
approved these changes
May 27, 2026
Rich7690
pushed a commit
to Rich7690/orka-github-actions-integration
that referenced
this pull request
May 28, 2026
* Allow reusing runner scale set if it exists
- Add `MANAGE_RUNNER_SCALE_SETS` environment variable to control whether to manage runner scale sets
If set to true, deletes any existing runner scale set with the same name on startup and deletes the scale set on exit (the old behavior).
If set to false, reuses an existing scale set if found and skips deletion on exit.
- Fix message session closing
The message session was never closed and it was impossible to reuse the scaleset
- Delete the scaleset if the active session is stale
In case the session was no properly closed, the scaleset needs to be deleted and a new one created
* Explain the logging change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
MANAGE_RUNNER_SCALE_SETSenvironment variable to control whether to manage runner scale setsIf set to true, deletes any existing runner scale set with the same name on startup and deletes the scale set on exit (the old behavior).
If set to false, reuses an existing scale set if found and skips deletion on exit.
Fix message session closing
The message session was never closed and it was impossible to reuse the scaleset
Delete the scaleset if the active session is stale
In case the session was no properly closed, the scaleset needs to be deleted and a new one created
Testing
Old Behavior
MANAGE_RUNNER_SCALE_SETSto trueNew Behavior
Fallback