Resolve issues with orphaned VMs when process restarts with in-flight jobs#64
Closed
Rich7690 wants to merge 3 commits into
Closed
Resolve issues with orphaned VMs when process restarts with in-flight jobs#64Rich7690 wants to merge 3 commits into
Rich7690 wants to merge 3 commits into
Conversation
Collaborator
|
As different users have different workflows, lets add this behind an option. |
Author
Thanks for the review. Added an environment variable to configure the behavior. |
Collaborator
|
@Rich7690 can you rebase your branch against main so the latest change can be applied. |
Author
|
Closing in favor of #66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the process restarts for any reason, the trackedVMs list is reset to zero on startup. This causes issues if you have many jobs in flight by leaving the VMs orphaned on the nodes and it has to be cleaned up manually. This addition adds a
orka3 vm liston startup to index all the VMs back into the list so it follows similar orphaned checks.I wasn't sure if this is the best way to check which VMs belong to the given runner scale set aside from prefix checks on the VM names since the orka API can't necessarily filter any other way.