Skip to content

Parse HTTPS record response#84

Closed
Cuthead wants to merge 2 commits intomacronut:mainfrom
Cuthead:type65
Closed

Parse HTTPS record response#84
Cuthead wants to merge 2 commits intomacronut:mainfrom
Cuthead:type65

Conversation

@Cuthead
Copy link
Copy Markdown

@Cuthead Cuthead commented Feb 8, 2026

	default:
		return 0, response
	}

At this point, type65 would be treated as default and the original response from upstream get returned ahead of the following code,

	if UseVaddr && (records.Index == 0) {
		records.Index = AddDNSLie(name, outbound)

effectively bypassing Vaddr.

The prior fix #82 added unnecessary complexity, I should utilize GetAnswers to parse HTTPS record response correctly, that would also prevent 65 being returned too early.

@Cuthead Cuthead marked this pull request as draft February 8, 2026 16:17
@Cuthead
Copy link
Copy Markdown
Author

Cuthead commented Feb 8, 2026

Not going to parse HTTPS record response because unnecessary alpn field from upstream will replace our defined one.

@Cuthead Cuthead closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant