Conversation
Give each wasm-pack crate its own CARGO_TARGET_DIR and run them via just's [parallel] attribute so app builds no longer serialize the two release compiles before Vite. Co-authored-by: Wolf Mermelstein <wolf@404wolf.com>
Point web build, preview, and deploy jobs at the existing Namespace web-ci remote sccache and persist cargo plus wasm-pack caches. Include agent_fold sources in the web artifact path filters. Co-authored-by: Wolf Mermelstein <wolf@404wolf.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change adds parallel cache-WASM and fold-WASM build targets with separate Cargo output directories. Web workflows now cache Bun, Cargo, and wasm-pack data, configure shared Namespace sccache, and report statistics. Web build jobs use the web build cache and a larger runner where applicable. Changes to fold-WASM crates now trigger relevant workflows. Tests validate generated workflow configuration. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is supported by the available evidence. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Web deploys currently compile cache-wasm, then agent-fold wasm, then Vite — sequentially, with no rustc cache. That rebuilds both wasm packages from scratch on every deploy.
Changes
Parallel.
just build-dev/build-staging/build-prodnow go through a[parallel] build-wasmrecipe. Eachwasm-packcrate gets its ownCARGO_TARGET_DIR(target/cache-wasm,target/agent-fold-wasm) so the two release compiles do not serialize on the workspace cargo lock. Vite still waits for both.Cache. Web build, preview, and deploy jobs now follow the existing typecheck pattern:
web-ciremote sccachewasm-optcache (same path as the sync-service worker job)CI still always rebuilds wasm (schema/engine changes can land without a version bump). The compiles just hit sccache instead of starting cold.
Path filters. Preview deploys and web PR checks now also run when
crates/agent_foldorcrates/agent_runtime_protocolchange.Tested
just --dry-run build-devemits bothwasm-packcommands, then Vitecargo test -p xtask_workflows— 28 passed, including new coverage for the build/preview/deploy cache wiringcargo x workflows --checkjust checkDid not run a full wasm-pack + Vite production build in this environment.