Conversation
An ask-question card hides the composer without unmounting it, so the stored draft comes back as a native echo and the text view stays empty. Rebind the editor when the card closes so that draft is painted again. Fixes pingdotgg#14053
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Opened upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
After an ask-question card closes, the composer shows the follow-up already stored for that thread. Opening or closing the card does not clear the draft.
The composer stays mounted while the card has the slot. When the card closes, the editor remounts and paints that stored draft. A fresh editor does not treat the draft as a native echo, which is what left the text view empty.
The same rebind runs when a failed-creation card gives the slot back, because that card hides the composer the same way.
Why
Fixes pingdotgg#14053
The question card hides the composer with
display: noneso the draft is kept. That also keeps the last keystroke classified as a native echo. When the card closes, iOS drops that echo if the text view no longer matches, so the composer looks empty until a thread switch mounts a new editor.Checklist
apps/mobile/src/native/composerEditorRevision.test.tscovers the rebind.Grok 4.7 in Cursor.