Skip to content

fix(server): hold background liveness until a waking task resumes - #55

Closed
macodev00 wants to merge 1 commit into
mainfrom
cursor/suppress-resume-completion-alert-7569
Closed

macodev00 wants to merge 1 commit into
mainfrom
cursor/suppress-resume-completion-alert-7569

Conversation

@macodev00

Copy link
Copy Markdown
Owner

What Changed

A Claude task notification that arrives after the parent turn has settled now keeps the thread's background liveness as working until the follow-up turn starts. The completion sound, toast, and desktop notification share sidebar status, so none of them fire in that gap.

A completion that does not resume the provider still clears liveness and alerts once. Approvals, questions, and failures still alert immediately.

Why

When a subagent or monitor finished, background liveness cleared before the agent resumed. The thread read as ready with the waiting turn's completedAt, and the shared completion trigger treated that gap as a finished run. The alert fired, then fired again when the follow-up turn actually settled.

The handoff is the task notification with no turn open, and the resume is the next turn.started. Holding liveness across those two events keeps the shell off ready for the whole gap, including while the model is starting the follow-up.

Fixes pingdotgg#13625

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes (no visual change)
  • I included a video for animation/interaction changes (no animation change)
Open in Web Open in Cursor 

A Claude task notification after the parent turn settles cleared
background liveness before the follow-up turn started. The thread
read as ready in that gap, so the shared completion trigger played
the sound, toast, and desktop notification. Mark that completion as
resuming the provider and keep liveness working until the follow-up
turn starts.

Fixes pingdotgg#13625

Co-authored-by: maco <macodev00@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Sep 27, 2026
@macodev00 macodev00 closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Completion sound fires when subagents or monitors finish, even though the agent resumes working

2 participants