Skip to content

fix(server): omit empty AskUserQuestion question in thread snapshot - #50

Closed
macodev00 wants to merge 42 commits into
mainfrom
cursor/askuserquestion-omit-empty-question-75a9
Closed

fix(server): omit empty AskUserQuestion question in thread snapshot#50
macodev00 wants to merge 42 commits into
mainfrom
cursor/askuserquestion-omit-empty-question-75a9

Conversation

@macodev00

@macodev00 macodev00 commented Sep 26, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Owner

What Changed

projectQuestionToolInput omits question when an AskUserQuestion entry has no question text.

Why

Entries with header and options but no question (including a streamed questions: [{}]) were projected as { question: undefined }. Schema.Unknown rejected that payload, so GET /api/orchestration/threads/:id and the WebSocket snapshot returned an empty HTTP 400 and the thread never loaded.

Clients already read record(question)?.question, so a missing key is safe. No database rewrite is required.

The branch is one commit ahead of pingdotgg/t3code main (a21b42ce). This fork's main is behind that, so the compare here also lists commits that are already on upstream.

Fixes pingdotgg#13762

Checklist

  • This PR is small and focused
  • I explained what changed and why
Open in Web Open in Cursor 

aaditagrawal and others added 30 commits September 25, 2026 16:04
@aaditagrawal @shivamhwp @claude
fix: update OpenAI logo to current brand asset (pingdotgg#13611)
e55e731 
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@SunkenInTime @devin-ai-integration @shivamhwp
fix(mobile): render assigned project icons in chat list (pingdotgg#12810
1c12706 
)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
@maria-rcks @Yash-Singh1
feat(usage): read cursor, opencode, and antigravity history (pingdotg…
e5a46d6 
…g#10409)

Co-authored-by: Yash Singh <saiansh2525@gmail.com>
@yashranaway @shivamhwp
fix(sqlite): retry failed statement preparations (pingdotgg#10584)
d06f0ff 
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
@none23
fix(mobile): scale Android controls with appearance text size (pingdo…
7a12aff 
…tgg#13356)
@mackinleysmith
fix(web): return focus to the composer after saving a citation note (p…
a4f6078 
…ingdotgg#13450)
@yordis
feat(observability): honor the standard OTLP endpoint, headers, and p…
fd996d1 
…rotocol variables (pingdotgg#13492)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@t3dotgg @claude
fix(terminal): settling a thread closes its idle shells (pingdotgg#13673
1a0c915 
)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Yash-Singh1
fix(server): load Cursor keyring with createRequire (pingdotgg#13678)
f5bd2fd
@shivamhwp
perf(server): avoid rereading unchanged files in review previews (pin…
4293433 
…gdotgg#13395)
@yordis
feat(desktop): honor the standard OTLP variables in the main process …
2598ce7 
…and WSL backends (pingdotgg#13641)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@t3-code @juliusmarminge
fix(web): restore compact provider instance badges (pingdotgg#13700)
ed809f7 
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
@AKolenda
perf(mobile): lighter Home rows away from the viewport (pingdotgg#13702)
525af2d
@Yash-Singh1
fix(usage): price Cursor cache savings by base model (pingdotgg#13731)
aade3a6
@AKolenda @juliusmarminge @claude
perf(mobile): render Home rows further ahead while scrolling (pingdot…
595a1e1 
…gg#13705)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@yordis
refactor(observability): name each service after its application (pin…
2a9832b 
…gdotgg#13699)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@t3dotgg @claude
perf(server): stop remapping every thread on each thread event (pingd…
c216ba4 
…otgg#13720)

Co-authored-by: Claude <noreply@anthropic.com>
@t3dotgg @claude
Remove unused items tracking from Claude adapter state (pingdotgg#13718)
5660ab5 
Co-authored-by: Claude <noreply@anthropic.com>
@t3dotgg @claude
feat(observability): name the command on subprocess spans (pingdotgg#…
20885ce 
…13701)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
fix(cli): t3 triage points agents at log files that exist (pingdotgg#…
7c901a3 
…13685)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
fix(server): the SQLite WAL file shrinks back after large writes (pin…
8aa5be2 
…gdotgg#13684)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
feat(cli): summarize the server trace file from the command line (pin…
75bf92e 
…gdotgg#13698)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
perf(server): pull request sync reads only threads with linked pull r…
6530de0 
…equests (pingdotgg#13704)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
feat(observability): write a server heap snapshot on SIGUSR2 (pingdot…
1dc8cbe 
…gg#13694)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
perf(server): shutdown no longer rewrites every stopped session row (p…
574b180 
…ingdotgg#13688)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
perf(server): build the thread list snapshot without decoding it twice (
b6eefc9 
pingdotgg#13693)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
fix(client): slow servers finish loading the thread list instead of l…
b2577d6 
…oading it twice (pingdotgg#13683)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
perf(web): hidden terminal drawers no longer keep full thread history…
6989856 
… in memory (pingdotgg#13686)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
perf(server): per-thread settlement and PR checks no longer rebuild t…
3b0a495 
…he whole thread list (pingdotgg#13691)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@AKolenda
fix(mobile): running threads open at the latest message (pingdotgg#13530
ecd3237 
)
t3dotgg and others added 12 commits September 25, 2026 20:38
@t3dotgg @claude
feat(observability): record event loop stalls in the server trace (pi…
ee18e56 
…ngdotgg#13697)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg @claude
perf(server): stop re-running git for every project each minute (ping…
999161e 
…dotgg#13689)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Gigioxx
fix(usage): hide the Cursor keychain prompt when Cursor isn't set up (p…
94c4216 
…ingdotgg#13714)
@otavio @github-actions @claude
feat(web): add chat width setting for wide screens (pingdotgg#11594)
04c15f3 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@shirishpothi
fix(opencode): accept v2 serve ready line when spawning server (pingd…
4408bf5 
…otgg#13651)
@ishaanko
fix(editors): stop treating the agy CLI as the Antigravity IDE (pingd…
1e844a3 
…otgg#7079)
@otavio
fix(web): make the empty workspace draggable on desktop (pingdotgg#13713
eeea71a 
)
@bfowler @claude
fix(server): installed editors no longer vanish when discovery is slow (
dd8332d 
pingdotgg#13669)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@GaMeRaM
fix(git): exclude SSH ports from provider URLs (pingdotgg#12537)
29a3266
@ValeraZSD
fix(web): Mod+B bolds on non-Latin layouts (pingdotgg#13409)
5d707bb
@t3dotgg @claude
fix(server): prune expired replay-protection files from the secrets d…
a21b42c 
…irectory (pingdotgg#13695)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@macodev00
fix(server): omit empty AskUserQuestion question in thread snapshot
78fdd66 
AskUserQuestion entries that have header and options but no question text were projected as { question: undefined }. Schema.Unknown rejects that value, so the thread snapshot returned an empty HTTP 400.

Leave the question key out when there is no text. Clients already read it with record(question)?.question.

Fixes pingdotgg#13762
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Sep 26, 2026
@macodev00 macodev00 closed this Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(server): thread snapshot returns empty HTTP 400 when an AskUserQuestion entry has no question text