Conversation
item.completed detail is a full snapshot. A nonempty buffered or already projected prefix was kept and the rest of the reply was dropped. When detail strictly extends that accumulated text, persist only the missing suffix.
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
When an assistant
item.completedsnapshot strictly extends text already accumulated (projected plus still buffered), ingestion persists only the missing suffix.Equal, empty, and divergent snapshots keep the streamed text.
Why
Codex custom-provider replies were truncated even though
item.completedcarried the full message. Finalization preferred a nonempty buffer, and the completion call site withheld the snapshot whenever the projected message was already nonempty. A short prefix such asHi! Iwas saved and marked complete.Fixes pingdotgg#13436
UI Changes
Checklist