Conversation
t3 triage labeled the CLI package version as the installed version, so npx t3 triage diagnosed against that binary instead of the desktop app or service the bug happened on. The context now names the triage CLI separately and records serverVersion from the live server when the recorded pid still owns the process. A stalled body, a reused pid, or a corrupt origin falls back instead of aborting. The playbook asks which version, device, and surface the bug happened on before cloning. Fixes pingdotgg#13337 Co-authored-by: maco <macodev00@users.noreply.github.com>
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Superseded: upstream READY already opened and closed after Macroscope Not approved. Leaving fork PR closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
t3 triagenow labelspackageJson.versionas the triage CLI version and, whenserver-runtime.jsonhas a live pid that still belongs to that server, readsserverVersionfromGET /.well-known/t3/environmentand records it as the local server version. The playbook tells the agent to ask which version, device, and surface the bug happened on, then check the probed server version against that answer.A stalled response body, a reused pid, or a corrupt origin falls back to unavailable or not-running instead of hanging or aborting triage.
Why
npx t3 triagewas presenting the CLI package version as the installed app version, so the agent cloned the wrong tree. The local server already publishes its build on the unauthenticated environment descriptor. The probe has to ignore a pid that no longer belongs to the recorded server, stop waiting when the body never finishes, and keep writing context whenoriginis not a URL.Fixes pingdotgg#13337
pingdotgg#13337
UI Changes
None.
Checklist