Conversation
A single matching byte, or a prefix of typed input, was enough to treat the pty as echoing. Local echo now stays off until the pty finishes the outstanding input and has echoed at least two characters on the line, so an echo-disabled prompt cannot paint the next secret key. Co-authored-by: maco <macodev00@users.noreply.github.com>
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Superseded: upstream READY already opened and closed after Macroscope Not approved. Leaving fork PR closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Android terminal local echo paints a typed key only after the pty has finished echoing the outstanding input and at least two characters on that line. A prefix of what was typed, including a single unrelated byte such as
a, does not turn the gate on. Later keys on an echoed line still paint locally and are reconciled when pty bytes arrive. A control key that produces no output no longer holds the rest of the line once a later character is echoed.Fixes pingdotgg#12756
Why
Echo-disabled prompts (
read -s, API tokens) must not be drawn. Matching pty output against the start of pending input treated unrelated output as a verified echo, then painted the next secret key. Trust now requires a finished echo of the outstanding input, not a prefix.UI Changes
Android terminal only. No new chrome. Echo-on typing paints after two confirmed characters; echo-off prompts stay blank.
Checklist