Conversation
…case screenshots (pingdotgg#13316) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
…otgg#11580) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…3355) Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Keep the thread binding update inside the start lock and re-read it after recovery acquires that lock, so a waiting recovery cannot restart the instance that was just replaced. A refused replacement keeps the live query and its MCP credential. A failed start revokes the credential when the previous adapter is gone. Claude still refuses replacement, including rollback, while child tasks are running. Fixes pingdotgg#12694
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Superseded: upstream pingdotgg#13380 already opened and closed after Macroscope Not approved (cap HIT). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Claude session start and recovery for one thread share one lock. The new session binding is written before that lock is released, and recovery re-reads the binding after it acquires the lock.
Fixes pingdotgg#12694
Why
A concurrent recovery could restart the old provider instance after the start lock was released but before the new binding was recorded. It could also keep using a binding snapshot taken before it waited for the lock. Either path left two instances running and made the MCP credential timing-dependent.
UI Changes
None.
Checklist