Conversation
…case screenshots (pingdotgg#13316) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
…otgg#11580) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…3355) Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Printable keys were drawn only after a remote round trip. Paint a key only after the pty has echoed an earlier one verbatim, and clear that gate on any other output so an echo-off prompt never shows the secret. Co-authored-by: maco <macodev00@users.noreply.github.com>
github-actions
Bot
added
vouch:trusted
|
@coderabbitai review |
Owner
Author
|
Superseded by upstream READY pingdotgg#13362 (same head). Closing fork-only PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Android terminal keystrokes paint before the remote pty echoes them, but only after that pty has already echoed a printable key verbatim. Any other output, including
read -s -p 'API token: ', clears the gate so the secret is never drawn. A control key and a pending-input cap hold painting until the pty catches up.Fixes pingdotgg#12756
Why
Characters were drawn only after a full attach round trip, so every key on a phone felt late. Prompt-label checks still painted echo-off input that was not labeled as a password. The pty echo itself is the gate: unknown and echo-off stay on the remote path.
UI Changes
This changes when typed characters appear in the Android terminal. Layout is unchanged. This environment has no Android emulator and no device, so there is no before/after recording. The gate is covered by
TerminalLocalEchoTest.iOS still paints from the remote buffer.
Checklist
Screenshots do not show the latency. A recording needs a device build of the native terminal module.