Skip to content

Changed testcase properties to use Label to match mstest filter format #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincentleungrsm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed testcase properties to use Label to match mstest filter format #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Machine.Specifications.Runner.VisualStudio/Execution/SpecificationFilterProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ public class SpecificationFilterProvider : ISpecificationFilterProvider

private readonly Dictionary<string, TestProperty> testCaseProperties = new Dictionary<string, TestProperty>(StringComparer.OrdinalIgnoreCase)
{
[TestCaseProperties.FullyQualifiedName.Id] = TestCaseProperties.FullyQualifiedName,
Copy link

@jsskeen-utah jsskeen-utah Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the Id property has previously been used for. Does this have to be changed from Id to Label or could we include both? Perhaps you could link to the source of other test runners where they do the same thing?

[TestCaseProperties.DisplayName.Id] = TestCaseProperties.DisplayName
[TestCaseProperties.FullyQualifiedName.Label] = TestCaseProperties.FullyQualifiedName,
[TestCaseProperties.DisplayName.Label] = TestCaseProperties.DisplayName
};

private readonly Dictionary<string, TestProperty> traitProperties = new Dictionary<string, TestProperty>(StringComparer.OrdinalIgnoreCase)
Expand Down