Skip to content

Defer the frame-representations witness to unblock #33 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macanderson merged 1 commit into from
Jul 22, 2026
+9 −0
Merged

Defer the frame-representations witness to unblock #33 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions contextgraph-types/tests/frame_representation_witness.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,16 @@ const LEGACY_FULL_FRAME_JSON: &str = r#"{
"token_cost": 412
}"#;

// NOTE: `#[ignore]` — this is a red witness for the not-yet-built
// **frame-representations** feature (reference frames that omit inline
// `content` and carry `content_ref` + `canonical_content_hash`). Implementing
// it is a normative wire change (`content` becomes optional; new fields added)
// and must go through its own proposal + ADR per `GOVERNANCE.md`; it is out of
// scope for the pre-freeze sweep this test currently blocks. The witness is
// kept (not deleted) as executable documentation of the intended shape — file a
// tracking issue for the feature and remove the `#[ignore]` when it lands.
#[test]
#[ignore = "witness for the unbuilt frame-representations feature; needs its own proposal + ADR — see the note above"]
fn reference_frame_without_inline_content_deserializes() {
// Fails on current code: `content` is a required String field, so serde
// rejects a reference frame that (correctly) omits inline content.
Expand Down
Loading