chore(repo): ignore .vercel and drop the stale npm lockfile#39
Draft
macanderson wants to merge 1 commit into
Draft
chore(repo): ignore .vercel and drop the stale npm lockfile#39macanderson wants to merge 1 commit into
macanderson wants to merge 1 commit into
Conversation
The Vercel project is now linked to this repo for git-driven deploys, so `vercel link` writes a `.vercel/` directory into every checkout. Ignore it rather than committing project/org IDs. `site/` also carried both `package-lock.json` and `pnpm-lock.yaml`. Vercel resolves the ambiguity in pnpm's favour, but a local `npm install` does not: npm's flat node_modules hoists `@types/mdx` up from fumadocs, which is exactly what masked the missing `@types/mdx` declaration fixed in #36 — the site built locally and failed type checking on Vercel. Keep pnpm as the single source of truth so a clean local install matches the build image.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up housekeeping from wiring this repo to Vercel for git-driven deploys.
Changes
.gitignore: add.vercel— the project is now linked, sovercel link/vercelwrites a.vercel/directory into every checkout. Ignore it instead of committing project/org IDs.site/package-lock.json—site/carried both an npm and a pnpm lockfile.Why the lockfile matters
Vercel resolves the two-lockfile ambiguity in pnpm's favour (
Detected pnpm-lock.yaml 9 … Using pnpm@10.x). A localnpm installdoes not: npm's flatnode_moduleshoists@types/mdxup from fumadocs, somdx/typesresolves locally even when it is undeclared.That is precisely what masked the bug fixed in #36 — the site type-checked locally and failed on Vercel with
Cannot find module 'mdx/types'. Keeping pnpm as the single source of truth makes a clean local install match the build image.Verification
pnpm install --frozen-lockfile, thenpnpm build(16 routes prerendered) andpnpm test(5/5) from a clean worktree withpackage-lock.jsonremoved.git-sourced preview deployment that reached Ready with no manual step.