Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 28 additions & 17 deletions lib/desugaring.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ def all_the_sugar(recipients, event, message)
#
# Copy the contents of the previous method here and remove this sugar.
#
def desugared_poetry(recipients, event, message)
implement_me!
def desugared_poetry recipients, event, message
mail message,
to: recipients.map(&:email),
subject: "You’re invited to #{event.title} on #{event.date}"
end

# Ruby allows you to pass arguments identified by name instead of just by position. They are really just
Expand All @@ -35,8 +37,9 @@ def desugared_poetry(recipients, event, message)
#
# Copy the contents of the previous method here and remove this sugar.
#
def desugared_named_args(recipients, event, message)
implement_me!
def desugared_poetry recipients, event, message
mail message, {to: recipients.map(&:email),
subject: "You’re invited to #{event.title} on #{event.date}"}
end

# Ruby’s general syntax for hashes is `{key => value, key => value, ...}`. Because it is so common to use
Expand All @@ -50,8 +53,9 @@ def desugared_named_args(recipients, event, message)
#
# Copy the contents of the previous method here and remove this sugar.
#
def desugared_symbol_keys(recipients, event, message)
implement_me!
def desugared_poetry recipients, event, message
mail message, {:to => recipients.map(&:email),
:subject => "You’re invited to #{event.title} on #{event.date}"}
end

# You may be wondering how `map(&:email)` works. When you precede the last argument of a method call with
Expand All @@ -69,8 +73,9 @@ def desugared_symbol_keys(recipients, event, message)
#
# Copy the contents of the previous method here and remove this sugar.
#
def desugared_attr_proc(recipients, event, message)
implement_me!
def desugared_poetry recipients, event, message
mail message, {:to => recipients.map{|x| x.email},
:subject => "You’re invited to #{event.title} on #{event.date}"}
end

# You may recall from the Ruby koans that when you put `#{something}` in a `"`-delimited string, Ruby will
Expand All @@ -87,8 +92,9 @@ def desugared_attr_proc(recipients, event, message)
#
# Copy the contents of the previous method here and remove this sugar.
#
def desugared_interpolation(recipients, event, message)
implement_me!
def desugared_poetry recipients, event, message
mail message, {:to => recipients.map{|x| x.email},
:subject => "You’re invited to " + (event.title).to_s + " on " + (event.date).to_s}
end

# Ruby tracks local variables lexically at compile time. Wherever you say `x = y`, the compiler assumes that
Expand All @@ -109,8 +115,9 @@ def desugared_interpolation(recipients, event, message)
# Copy the contents of the previous method here and remove this sugar.
# (Think: which names are local variables, and which are not?)
#
def desugared_implicit_self(recipients, event, message)
implement_me!
def desugared_poetry recipients, event, message
self.mail message, {:to => recipients.map{|x| x.email},
:subject => "You’re invited to " + (event.title).to_s + " on " + (event.date).to_s}
end

# In Ruby, unlike Python, there are no properties distinct from method calls. When you say `x.y`, you are
Expand All @@ -130,8 +137,9 @@ def desugared_implicit_self(recipients, event, message)
# At this point, you should have code that looks remarkably like Javascript. Not _exactly_ like it,
# but structurally quite similar!
#
def desugared_implicit_parens(recipients, event, message)
implement_me!
def desugared_poetry recipients, event, message
self.mail(message, {:to => recipients.map{|x| x.email()},
:subject => "You’re invited to " + (event.title()).to_s() + " on " + (event.date()).to_s()})
end

# In Ruby, every value is an object and every action is a method call. That includes operators. A binary
Expand All @@ -152,9 +160,12 @@ def desugared_implicit_parens(recipients, event, message)
# P.P.P.S. For full credit on this one, note that addition is left-associative: the things on the left
# get added before the things on the right. (a + b + c) means ((a + b) + c), NOT (a + (b + c)).
#
def desugared_operators(recipients, event, message)
implement_me!
end
def desugared_poetry recipients, event, message
self.mail(message,{:to => recipients.map{|x| x.email()},
:subject => "You’re invited to ".+( (event.title()).to_s().+( " on ".+( (event.date()).to_s() ) ) )
}
)
end

# Compare that to the version at the top.
#
Expand Down
5 changes: 5 additions & 0 deletions lib/retail_transaction.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def paid?
state :processing_payment
state :payment_declined
state :settled
state :refunded

event :check_out do
transitions from: :ringing_up, to: :collecting_payment,
Expand All @@ -61,5 +62,9 @@ def paid?
event :payment_declined do
transitions from: :processing_payment, to: :payment_declined
end

event :refund do
transitions from: :settled, to: :refunded
end
end
end
36 changes: 35 additions & 1 deletion test/retail_transaction_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
end

it "starts out empty" do
assert_equal true, tx.empty?
assert_equal true, tx.empty?
end

it "cannot check out if no items" do
Expand Down Expand Up @@ -64,6 +64,11 @@
assert_equal false, tx.collecting_payment?
assert_equal true, tx.processing_payment?
end

it "cannot refund payment" do
assert_invalid_transition { tx.refund! }
end

end

describe "processing payment" do
Expand Down Expand Up @@ -103,6 +108,10 @@
assert_equal false, tx.settled?
assert_equal true, tx.payment_declined?
end

it "cannot be refunded" do
assert_invalid_transition { tx.refund! }
end
end

describe "with declined payment" do
Expand Down Expand Up @@ -152,5 +161,30 @@
it "cannot be reopened" do
assert_invalid_transition { tx.reopen! }
end

it "can be refunded" do
tx.refund!
assert_equal false, tx.settled?
assert_equal true, tx.refunded?
end
end

describe "refunded purchase" do
before(:each) do
tx.add_item("bobcat")
tx.check_out!
tx.payment_info = "15 cents and a nail"
tx.process_payment!
tx.payment_authorized!
tx.refund!
end

it "cannot be refunded again" do
assert_invalid_transition { tx.refund! }
end

it "cannot be reopened" do
assert_invalid_transition { tx.reopen! }
end
end
end
4 changes: 2 additions & 2 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

# To see full test names when running tests:
#
# require "minitest/reporters"
# Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new
require "minitest/reporters"
Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

module Minitest::Assertions
def assert_invalid_transition
Expand Down