add toString methods for some graphics classes#44
Open
dandrake wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should now be
toStringmethods on all the classes commonly used by students, and for which having something sensible to use in a print statement or to see in the debugger is useful.One gap that remains, I think, is that it's still not very easy to interrogate a
GraphicsGrouporCanvasWindowand see what it contains. One approach could be to add a method similar totoStringthat iterates over the child objects and returns a large string with all of them, but that doesn't seem like a good solution. OTOH making it easier to get the children may not be what we want? Looking for feedback here.Fixes #42.