expose mouse button and modifiers from underlying AWT mouse event#41
expose mouse button and modifiers from underlying AWT mouse event#41dandrake wants to merge 1 commit into
Conversation
|
I tested this and it works as expected. I am looking for feedback on several bits, though:
|
|
For the failing regression tests -- on my Mac, I got that error and fixed it by changing the required Java version from 17 to 21. Looks like the failing tests did so because they do have version 17 -- do we need to still support that? I suspect so, but...maybe not? |
Fixes #28. We now have `getButton` and `getModifiers` methods and some associated constants for the buttons, events, and modifier key masks. I also added in `getEventId`, though that looks to `InputEvent.getModifiers` which was deprecated a very, very long time ago; we should consider changing that to use `getModifiersEx`.
300a624 to
1c28bd7
Compare
|
Per Paul's comment, it seems our approach is to suppress as much of the underlying AWT stuff as possible. So it seems fine to copy over all the event, button, and mask constants. |
Fixes #28.
We now have
getButtonandgetModifiersmethods and some associated constants. I also added ingetEventId, though that looks toInputEvent.getModifierswhich was deprecated a very, very long time ago; we should consider changing that to usegetModifiersEx.