feat(rules): show ancestor paths in the move-destination dropdown - #414
Open
Monkey7539 wants to merge 2 commits into
Open
feat(rules): show ancestor paths in the move-destination dropdown#414Monkey7539 wants to merge 2 commits into
Monkey7539 wants to merge 2 commits into
Conversation
Folders with the same name under different parents were indistinguishable in the move-to-folder pickers. Prefix each entry with its muted ancestor chain (Personal / Insurance) via a shared FolderPathLabel, and let the search box match any path segment or a parent/child query (delimiter-normalized), across the context menu, message pane pickers, mobile move sheet, and bulk-move picker. The delimiter and parent-path primitives live in folderDisplay.js and the sidebar tree builder imports them from there, so the tree and the pickers derive hierarchy from one source. Unit tests cover '/' and '.' delimited accounts, including folder names that contain the other account's delimiter. Closes maathimself#402 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The rule form's move-to-folder select listed bare folder names, making same-named folders under different parents indistinguishable. Reuse folderParentLabel for Parent / Child option labels, add a tooltip with the selected path on the closed control (a native option cannot host the pickers' two-tone/hover-scroll label), and show the move destination in the rules-list action summary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to #410, applying the same ancestor-path treatment to the inbox-rules form. The rule editor's move-destination dropdown listed bare folder names, so an account with
INBOX/Archiveand a rootArchive(orPersonal/InsurancevsBusiness/Insurance) showed identical entries and picking the right destination was guesswork. The rules list also summarized any move rule as just "Move", with no destination.Stacked on #410 — the first commit here is that PR's commit (this reuses its
folderParentLabelutil so the rules form, the pickers, and the sidebar tree all derive hierarchy from one source). Only theAdminPanel.jsxcommit is new; happy to rebase once the base lands.Changes
<select>labels each option with its ancestor chain:Ice Rentals / Groups / Beacon Hillinstead ofBeacon Hill, via the sharedfolderParentLabel.titletooltip with the selected folder's full path (a native<option>cannot host the pickers' two-tone label, but the opened dropdown already shows the full text untruncated).Move → Ice Rentals/Groups) so rules are tellable apart at a glance.Testing
npm run lintclean; full frontend suite passes (1686/1686).Contributor License Agreement
By submitting this pull request I confirm that:
third-party material and confirmed it is compatible with the CLA).
🤖 Generated with Claude Code