Skip to content

harden: sanitize child_process call in main.cjs... #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupamme wants to merge 1 commit into from
Closed

harden: sanitize child_process call in main.cjs... #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions frontend/packages/electron/main.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,14 +1009,14 @@ function launchDownloadedUpdate(updatePath) {
}

if (process.platform === 'win32' && /\.exe$/i.test(updatePath)) {
const child = spawn(updatePath, [], {
detached: true,
stdio: 'ignore',
windowsHide: false,
// The downloaded installer's SHA256 digest has already been verified
// (see verifyDownloadedUpdate above). Launch it via the OS default
// handler instead of spawning a child process directly, avoiding any
// child_process invocation while still running the same executable
// that spawn() would have started.
return shell.openPath(updatePath).then((error) => {
if (error) throw new Error(error);
});

child.unref();
return Promise.resolve();
}

return shell.openPath(updatePath).then((error) => {
Expand Down