feat(move-picker): hover-scroll truncated folder path labels - #411
Open
Monkey7539 wants to merge 2 commits into
Open
feat(move-picker): hover-scroll truncated folder path labels#411Monkey7539 wants to merge 2 commits into
Monkey7539 wants to merge 2 commits into
Conversation
Folders with the same name under different parents were indistinguishable in the move-to-folder pickers. Prefix each entry with its muted ancestor chain (Personal / Insurance) via a shared FolderPathLabel, and let the search box match any path segment or a parent/child query (delimiter-normalized), across the context menu, message pane pickers, mobile move sheet, and bulk-move picker. The delimiter and parent-path primitives live in folderDisplay.js and the sidebar tree builder imports them from there, so the tree and the pickers derive hierarchy from one source. Unit tests cover '/' and '.' delimited accounts, including folder names that contain the other account's delimiter. Closes maathimself#402 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Long parent/child labels ellipsize in the pickers with no way to read the remainder. On hover, when the label overflows, stop shrinking the segments and slide the text left marquee-style to reveal the clipped part (pace scales with distance, short delay filters quick passes), snapping back on leave. Applies to all pickers via FolderPathLabel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional follow-up to the ancestor-path labels from #402: a deep path like
Ice Rentals / Groups / Beacon Hillcan still truncate in a 320px picker, leaving no way to read the clipped part. On hover, a label that overflows slides left marquee-style to reveal the remainder, then snaps back on leave. Labels that fit are completely unaffected, and there is no motion on touch devices (no hover).Stacked on the labels PR — the first commit here is that PR's commit; only the
FolderPathLabel.jsxchange is new. Happy to rebase once the base lands, and equally happy to drop this one if the motion isn't wanted — it's deliberately separated so the core feature stands alone.Changes
FolderPathLabelgains hover measurement: while hovered the segments stop flex-shrinking (natural width) so the true overflow can be measured, then the content translates left by exactly the clipped amount. The reveal pace scales with distance (~80px/s, min 0.4s) and a 0.3s delay keeps quick mouse passes over the list from triggering slides.Testing
npm run lintclean; full frontend suite passes (1686/1686).Contributor License Agreement
By submitting this pull request I confirm that:
third-party material and confirmed it is compatible with the CLA).
🤖 Generated with Claude Code