Skip to content

ci: Update release workflow for npm OIDC authentication and bump up node version #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaissica12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Update release workflow for npm OIDC authentication and bump up node version #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-node@v6.0.0
with:
node-version: 18
node-version: 24
cache: yarn
cache-dependency-path: yarn.lock

Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-node@v6.0.0
with:
node-version: 18
node-version: 24
cache: yarn
cache-dependency-path: yarn.lock

Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-node@v6.0.0
with:
node-version: 18
node-version: 24
cache: yarn
cache-dependency-path: yarn.lock

Expand Down
16 changes: 13 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-node@v6.0.0
with:
node-version: 18
node-version: 24
cache: yarn
cache-dependency-path: yarn.lock

Expand All @@ -47,20 +47,30 @@ jobs:
name: Release and Sync Repos
runs-on: ubuntu-latest
needs: ['android-unit-tests', 'react-tests']
# OIDC permissions for npm trusted publishing
permissions:
contents: write
issues: write
pull-requests: write
id-token: write # Required for OIDC authentication with npm
steps:
- name: Checkout internal/development
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v6.0.0
with:
node-version: 18
node-version: 24
registry-url: 'https://registry.npmjs.org'

- name: Install node modules
run: yarn install

Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace on line 68 should be removed for cleaner formatting.

Suggested change

Copilot uses AI. Check for mistakes.
- name: Ensure npm CLI supports OIDC
run: npm install -g npm@latest

- name: Build SDK
run: yarn build

- name: Release
run: ./release.sh ${{ secrets.NPM_TOKEN}}
run: ./release.sh
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@
"app.plugin.js",
"plugin"
],
"publishConfig": {
"access": "public",
"provenance": true,
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'provenance' field is redundant in publishConfig since it's already specified as a CLI flag '--provenance' in release.sh. While both are valid, having it in only one location would be clearer. Consider removing it from either package.json or the CLI command.

Suggested change
"provenance": true,

Copilot uses AI. Check for mistakes.
"registry": "https://registry.npmjs.org"
Comment on lines +33 to +35
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in the publishConfig section uses 8 spaces instead of 2 spaces, which is inconsistent with the rest of the package.json file. This should be corrected to maintain consistent formatting.

Suggested change
"access": "public",
"provenance": true,
"registry": "https://registry.npmjs.org"
"access": "public",
"provenance": true,
"registry": "https://registry.npmjs.org"

Copilot uses AI. Check for mistakes.
},
"dependencies": {},
"peerDependencies": {
"react": ">= 16.0.0-alpha.12",
Expand Down
6 changes: 1 addition & 5 deletions release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
#!/usr/bin/env bash
: ${1?"NPM Token missing- usage: $0 {MY_NPM_TOKEN}"}

touch .npmrc;
echo "//registry.npmjs.org/:_authToken=$1" > .npmrc;
npm publish;
npm publish --provenance --access public
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '--access public' flag is redundant since it's already specified in package.json publishConfig. While both are valid, having it in only one location would be clearer. Consider removing it from the CLI command.

Suggested change
npm publish --provenance --access public
npm publish --provenance

Copilot uses AI. Check for mistakes.
Loading