Repository navigation
feat: default to effect v4 when the installed effect can't be detected - #71
Merged
Merged
Conversation
Installed effect 3 still gets v3 output and effect 4 gets v4 output; only the fallback (effect not resolvable, or no major in its version) changes from v3 to v4. Adds tests that run the generator against fixture projects with effect 3, effect 4, an unparseable version and no effect installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect v4 is the current stable line, so it becomes the fallback.
effectVersionstill overrides. Only the fallback changes: wheneffectcan't be resolved, or its version has no major, the generator now emits v4 instead of v3.tests/effectVersion.test.tsruns the built generator against fixture projects with effect 3, effect 4, an unparseable version, no effect, and aneffectVersionoverride.