Add powerhub charging binary sensor and optional update intervals#77
Open
ItsRebaseTime wants to merge 1 commit into
Open
Conversation
878f275 to
f562474
Compare
f562474 to
66f3a60
Compare
Contributor
|
Thanks for the suggestion. Refactoring the charge/vin status into a dedicated component was the right move. The original implementation focused on exposing raw register values, which—while technically accurate—is less relevant to the user than simply knowing the current state. Although I'm thinking changing the structure to individual sub component. |
Contributor
Author
|
@parker-int64 Could you give me a config yaml example of what you have in mind? I would be happy to do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added PowerHub binary sensor just to make a bit cleaner way to get the charging status without parsing the text sensor in lambdas.
Also noticed that there are no update interval configuration options for the sensors, so added those too.