Skip to content

Implement Core Engine Runtime Patches Derived from WAFlash Teardown & Ruffle Parity - #29

Merged
ClausValcaTD merged 2 commits into
mainfrom
feat/runtime-patches-waflash-teardown-3515955286987520045
Oct 9, 2026
Merged

ClausValcaTD merged 2 commits into
mainfrom
feat/runtime-patches-waflash-teardown-3515955286987520045

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Contributor

Applied critical engine runtime patches to WAFlash-ReFlexed derived from WAFlash teardown and Ruffle parity:

  1. URL normalization to absolute URLs and 4-parameter execution schema in WASM API and web runner (index.html).
  2. Corrected preloader frame and byte property evaluations (_totalframes, _framesloaded, getBytesLoaded/getBytesTotal) in SWFParser and gameswf.
  3. Updated DisplayList::place_object_matrix to preserve active character definitions during PlaceObject2 move transforms.
  4. Added AudioMixer::reopen_buffer() and exposed wasm_reopen_audio_buffer for audio ring buffer resynchronization.
  5. Added unit tests in tests/test_runtime_patches.cpp and registered in CMakeLists.txt.

PR created automatically by Jules for task 3515955286987520045 started by @ClausValcaTD

- Absolute URL resolution and 4-parameter WASM protocol enforcement.
- Preloader and loadMovie event timing fix to prevent 0==0 race condition.
- PlaceObject2 move preservation without discarding active character_id.
- AudioMixer reopen_buffer() resynchronization and WASM API export.
- Added test_runtime_patches unit test target.

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Fix dummy_swf header length in test_wasm_api to match 17-byte buffer size.
- Add gameswf_movie_def.h assertion patch in CMakeLists.txt.
- Ensure all 5 CTest unit test targets pass across platforms.

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@ClausValcaTD
ClausValcaTD merged commit 51c6227 into main Oct 9, 2026
3 of 5 checks passed
@ClausValcaTD
ClausValcaTD deleted the feat/runtime-patches-waflash-teardown-3515955286987520045 branch October 9, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant