Skip to content

Fix WASM audio wiring and m_defer_enterframe load check - #28

Merged
ClausValcaTD merged 1 commit into
mainfrom
fix-wasm-audio-defer-enterframe-9376543612685780374
Oct 4, 2026
Merged

ClausValcaTD merged 1 commit into
mainfrom
fix-wasm-audio-defer-enterframe-9376543612685780374

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Contributor
  • Implemented gameswf sound_handler in src/wasm_api.cpp connected to AudioMixer g_audio_mixer and updated wasm_get_audio_samples to stream from g_audio_mixer.
  • Fixed sibling clip load completion check in third_party/gameswf/gameswf/gameswf_sprite.cpp by replacing get_loaded_bytes() == 0 check with m_on_event_load_called == false.

PR created automatically by Jules for task 9376543612685780374 started by @ClausValcaTD

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ClausValcaTD
ClausValcaTD merged commit e069506 into main Oct 4, 2026
3 of 5 checks passed
@ClausValcaTD
ClausValcaTD deleted the fix-wasm-audio-defer-enterframe-9376543612685780374 branch October 4, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant