Repository navigation
Fix Windows libretro_flash externals and Emscripten jpeglib include - #27
Conversation
- Uncomment src/swf_parser.cpp, src/avm2_vm.cpp, and src/display_list.cpp in libretro_flash target to resolve 17 unresolved externals on Windows (MSVC). - Add -sUSE_LIBJPEG=1 and -sUSE_ZLIB=1 compile options to gameswf_core in EMSCRIPTEN block so jpeglib.h can be found at compile time. Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…lags - Uncomment src/swf_parser.cpp, src/avm2_vm.cpp, and src/display_list.cpp in libretro_flash target to resolve 17 unresolved externals on MSVC/Windows. - Add -sUSE_LIBJPEG=1 and -sUSE_ZLIB=1 compile options to gameswf_core in EMSCRIPTEN block so jpeglib.h can be found at compile time. Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
… options - Uncomment src/swf_parser.cpp, src/avm2_vm.cpp, and src/display_list.cpp in libretro_flash target to resolve unresolved externals on MSVC/Windows. - Add INTERFACE compile and link options (-sUSE_LIBJPEG=1 and -sUSE_ZLIB=1) to gameswf_core in the EMSCRIPTEN block so all dependent targets (such as test_wasm_api) properly compile and link against Emscripten's libjpeg and zlib. Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
… options - Uncomment src/swf_parser.cpp, src/avm2_vm.cpp, and src/display_list.cpp in libretro_flash target to resolve unresolved externals on MSVC/Windows. - Add INTERFACE compile and link options (-sUSE_LIBJPEG=1 and -sUSE_ZLIB=1) to gameswf_core in EMSCRIPTEN block so all dependent targets (such as test_wasm_api) compile and link against Emscripten's libjpeg/zlib. Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
1 participant
Fix Windows libretro_flash unresolved externals by including swf_parser.cpp, avm2_vm.cpp, and display_list.cpp in libretro_flash target.
Fix WASM jpeglib.h compilation failure by adding -sUSE_LIBJPEG=1 and -sUSE_ZLIB=1 to gameswf_core compile options under EMSCRIPTEN block.
PR created automatically by Jules for task 7504967270922370321 started by @ClausValcaTD