Repository navigation
Fix compiler_assert macro and time_t redefinition - #24
Conversation
- Replace legacy compiler_assert switch macro with C++11 static_assert in utility.h - Include time.h and add preprocessor guard around manual time_t typedef in tu_types.h - Add _CRT_SECURE_NO_WARNINGS and _CRT_NONSTDC_NO_WARNINGS MSVC compile definitions in CMakeLists.txt Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replace compiler_assert macro with C++11 static_assert in utility.h - Add preprocessor guards for time_t in tu_types.h - Add MSVC CRT definitions and _TIME_T in CMakeLists.txt - Add APPLE target link options for libretro_flash in CMakeLists.txt Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
1 participant
Fix cross-platform build failures for Clang/WASM and MSVC/Windows in gameswf without altering game logic.
PR created automatically by Jules for task 8783148534687596773 started by @ClausValcaTD