Repository navigation
fix(generator): prevent month labels from overlapping on partial first weeks - #2
Merged
Merged
Conversation
…t weeks GitHub's contribution calendar almost always starts on a partial week, which could flag two 'month changed' events one column (12px) apart — not enough room for two 3-letter labels, so they rendered stacked on top of each other. Enforce a minimum 36px gap between rendered labels; a month change that's too close to the previous label is skipped rather than drawn, and picked up cleanly at the next real boundary. Verified against the worst case (a mid-week start date straddling a month boundary) — extracted label x-coordinates confirm >=36px spacing in all cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's contribution calendar almost always starts on a partial week,
which could flag two "month changed" events one column (12px) apart
not enough room for two 3-letter labels, so they rendered stacked on
top of each other.
Enforce a minimum 36px gap between rendered labels; a month change
that's too close to the previous label is skipped rather than drawn,
and picked up cleanly at the next real boundary.
Verified against the worst case (a mid-week start date straddling a
month boundary) — extracted label x-coordinates confirm >=36px spacing
in all cases.