Skip to content

Fix flaky DuplexTest.duplexWithAuthChallenge #9564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kamilkrzywanski wants to merge 1 commit into from
+14 −1
Closed

Fix flaky DuplexTest.duplexWithAuthChallenge #9564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion okhttp/src/jvmTest/kotlin/okhttp3/DuplexTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,14 +496,27 @@ class DuplexTest {
fun duplexWithAuthChallenge() {
enableProtocol(Protocol.HTTP_2)
val credential = basic("jesse", "secret")
val duplexResponseSent = CountDownLatch(1)
val requestHeadersEndListener =
object : EventListener() {
override fun requestHeadersEnd(
call: Call,
request: Request,
) {
// Wait for the server to send the duplex response before acting on the 401 response
// and resetting the stream.
duplexResponseSent.await()
}
}
client =
client
.newBuilder()
.authenticator(RecordingOkAuthenticator(credential, null))
.eventListener(eventRecorder.eventListener + requestHeadersEndListener)
.build()
val body1 =
MockSocketHandler()
.sendResponse("please authenticate!\n")
.sendResponse("please authenticate!\n", duplexResponseSent)
.requestIOException()
.exhaustResponse()
server.enqueue(
Expand Down