target only upstream supported versions of Go - #159
Merged
Conversation
crockeo
changed the title
crockeo
commented
Jun 20, 2023
| linters: | ||
| disable-all: true | ||
| enable: | ||
| - depguard |
Contributor
Author
There was a problem hiding this comment.
depguard was reporting erroneous results and, without configuration, doesn't provide much value. I'm choosing to remove it instead of figuring out what caused it to break.
tomwans
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the Golang release policy:
gostatsdoesn't need to support1.17or1.18anymore, so:go.modversion to be1.18to mark that we will need generics support in [RFC] replacesync.Mapwithlru.Cache#158.Also going through and fixing lint errors with 325decb so that this PR can be merged.